search

cameroncros / OctoPrint-DiscordRemote

Discord plugin for OctoPrint
MIT License
66 stars 34 forks source link

Presence control is inverted #194

Closed EvilGremlin closed 2 years ago

EvilGremlin commented 3 years ago

2.69.0, nuff said

cameroncros commented 3 years ago

Gonna need you to elaborate, I have no idea what you are talking about.

On Thu, Jun 17, 2021 at 7:06 PM EvilGremlin @.***> wrote:

2.69.0, nuff said

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/cameroncros/OctoPrint-DiscordRemote/issues/194, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAK7FLZLJMCSXNOPVQ57SHDTTG3KPANCNFSM463G7TEQ .

EvilGremlin commented 3 years ago

I don't know if it's even possible to elaborate... Screenshot_20210618_112041 It's function is inverted.

cameroncros commented 3 years ago

So, I think what your saying is that when the "Enable Presence" button is enabled, the presence is not update, and when you disable it, it is?

I haven't managed to replicate it yet. From inspecting the code, it all looks correct to me. This may be yet another quirk of the home grown discord bot, which I am currently removing.

Once version 3 is released, I will ping you on this ticket to test, it should work far better then.

On Fri, 18 Jun 2021, 6:22 pm EvilGremlin, @.***> wrote:

I don't know if it's even possible to elaborate... [image: Screenshot_20210618_112041] https://user-images.githubusercontent.com/22657714/122530597-50a19200-d027-11eb-9f77-92a18aaba218.png It's function is inverted.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/cameroncros/OctoPrint-DiscordRemote/issues/194#issuecomment-863856782, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAK7FLZ45FOHMG4YK2QVOULTTL66DANCNFSM463G7TEQ .

EvilGremlin commented 3 years ago

For me it's perfectly repeatable, I have this issue on 3 different machines.

cameroncros commented 3 years ago

Okay, I will investigate more thoroughly then, thank you

On Sat, 19 Jun 2021, 4:30 pm EvilGremlin, @.***> wrote:

For me it's perfectly repeatable, I have this issue on 3 different machines.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/cameroncros/OctoPrint-DiscordRemote/issues/194#issuecomment-864364052, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAK7FL46MF53FXFKETXESJDTTQ2PZANCNFSM463G7TEQ .

cameroncros commented 3 years ago

Yup, my printer also has it inverted, interesting.

On Sat, 19 Jun 2021, 5:40 pm Cameron Cross, @.***> wrote:

Okay, I will investigate more thoroughly then, thank you

On Sat, 19 Jun 2021, 4:30 pm EvilGremlin, @.***> wrote:

For me it's perfectly repeatable, I have this issue on 3 different machines.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/cameroncros/OctoPrint-DiscordRemote/issues/194#issuecomment-864364052, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAK7FL46MF53FXFKETXESJDTTQ2PZANCNFSM463G7TEQ .

EvilGremlin commented 3 years ago

Okay, finally got some printing to do and when presence sorta works is always show "playing None", which mens it doesn't work at all...

sonjamichelle commented 2 years ago

Sooo, Bot Presence is a no-go for a while?

I still get progress images in my discord so that is good. Commands don't, but honestly I never used them. I'm usually sitting at my desk next to my printers and have external access to OctoFarm and OctoPrint if I need to cancel a print or object.

Hopefully ya find time to work on the plug-in, it is a really neat plugin!

Thanks for your contribution and hard work!!!!

cameroncros commented 2 years ago

@sonjamichelle Short term yes, presence may be broken. But, if you can't get commands working, it is likely that it is part of your problem to begin with. Check and see if there are any errors in the logs, try restarting and see if it responds to commands initially? If you have commands working, presence should also work, but the checkbox needs to be off instead of on.

sonjamichelle commented 2 years ago

@cameroncros It looks like I had a typo in my base url. When my current print is done I'll fix and check my settings then do a reboot.

Also I don't seem to have allow_scripts: true in my config.yaml. Is that the config file? And where do I insert.

Odd, everything was working a while, but I DID make lots of changes to my OctoPrint install the past month or so. Soooo some things may have gotten buggered, lol.

Like I said, presence is not a HUGE issue right now. I'm getting snapshots at the moment and that is good. the rest can happen when it happens. ;-)