cameroncros / OctoPrint-DiscordRemote

Discord plugin for OctoPrint
MIT License
68 stars 32 forks source link

Buttons! #197

Closed DigiVore-Programing closed 3 years ago

DigiVore-Programing commented 3 years ago

Is your feature request related to a problem? Please describe. No, but it's something useful.

Describe the solution you'd like Discord has added buttons to the UI, and discord.py has it now. Buttons would simply the bot

Describe alternatives Reaction controls and such

cameroncros commented 3 years ago

I still haven't completed discord.py support, but maybe once that is done it could be looked at. I am not particularly keen to work on this though, but I will accept any contributions.

DigiVore-Programing commented 3 years ago

If you would like, me and a friend could help you switch to Discord.JS, which is better in many ways, and works better. However you do need to install Javascript I think...

On Mon, Aug 9, 2021, 12:29 AM Cameron @.***> wrote:

I still haven't completed discord.py support, but maybe once that is done it could be looked at. I am not particularly keen to work on this though, but I will accept any contributions.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/cameroncros/OctoPrint-DiscordRemote/issues/197#issuecomment-894981380, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJI7E5SBOK277Z44LXIOCIDT35YWJANCNFSM5BZIC56A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

cameroncros commented 3 years ago

Discord.js is not gonna work, OctoPrint is python, so plugins need to be python. Only reason I am using my own hand-rolled discord client instead of discord.py is because of Octoprint not supporting python 3. If you have any experience with discord.py, I'll happily accept PRs.

On Mon, 9 Aug 2021, 5:14 pm DigiVore-Programing, @.***> wrote:

If you would like, me and a friend could help you switch to Discord.JS, which is better in many ways, and works better. However you do need to install Javascript I think...

On Mon, Aug 9, 2021, 12:29 AM Cameron @.***> wrote:

I still haven't completed discord.py support, but maybe once that is done it could be looked at. I am not particularly keen to work on this though, but I will accept any contributions.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/cameroncros/OctoPrint-DiscordRemote/issues/197#issuecomment-894981380 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AJI7E5SBOK277Z44LXIOCIDT35YWJANCNFSM5BZIC56A

. Triage notifications on the go with GitHub Mobile for iOS < https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android < https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/cameroncros/OctoPrint-DiscordRemote/issues/197#issuecomment-895003906, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAK7FL7TETXRY6FKHO77WATT3557DANCNFSM5BZIC56A .

DigiVore-Programing commented 3 years ago

Another idea, being able to move the extruder before every snapshot (like octolapse)

I'm gonna close this issue, since you've got the idea, and I might PR it.

cameroncros commented 3 years ago

Thats a pretty interesting idea, but may not be terribly easy, as far as I know, octolapse modifies the gcode before its sent, so that might be as easy for this? It might be possible though, but I will leave that to you.