search

cameroncros / OctoPrint-DiscordRemote

Discord plugin for OctoPrint
MIT License
68 stars 32 forks source link

Updated to OctoPrint 1.7 stable. got this : #202

Closed SgtKiLLx closed 2 years ago

SgtKiLLx commented 2 years ago

octoprint-discordremote 2.70.0 requires websocket-client==0.57, but you have websocket-client 0.59.0 which is incompatible

jneilliii commented 2 years ago

Any version of websocket-client version newer than 0.59 is python3 only. I suppose OctoPrint upgraded to the latest stable version supported by both python2 and python3 with the latest update which is 0.59.0 and @cameroncros just needs to update the requirements.txt file to the newer version. If that is the case, you could verify by copying/pasting this URL into Plugin Manager > Get More > ...from URL and clicking Install.

https://github.com/jneilliii/OctoPrint-DiscordRemote/archive/refs/heads/master.zip
jneilliii commented 2 years ago

Unfortunately, it seems that the 0.59 version works for installing, but something in the underlying code isn't working. @SgtKiLLx may provide more details soon as he was testing for us.

SgtKiLLx commented 2 years ago

Screenshot 2021-10-11 172137

after installing @jneilliii 's fork, setting up the bot. bot not showing online. sending status command through octoprint worked, briefly.

cameroncros commented 2 years ago

The requests websocket-client version is very sensitive, and different versions break in weird ways.

If you are interested, the discordlib branch in my repo has a partially working discord.py implementation. It is very rough around the edges and doesnt work perfectly yet, (Double messages, no snapshots, etc) but it does work.

I will get a download url shortly.

cameroncros commented 2 years ago

Download url is:

https://github.com/cameroncros/OctoPrint-DiscordRemote/archive/refs/heads/discordlib.zip

You'll need python 3.

Thanks @jneilliii for trying to fix it, I appreciate the effort.

jneilliii commented 2 years ago

So @cameroncros is the requests module that you mention what is actually breaking the websocket-client version or is that something different?

SgtKiLLx commented 2 years ago

The requests version is very sensitive, and different versions break in weird ways.

If you are interested, the discordlib branch in my repo has a partially working discord.py implementation. It is very rough around the edges and doesnt work perfectly yet, (Double messages, no snapshots, etc) but it does work.

I will get a download url shortly.

No problem Cameron. No rush, whenever you can work on it, .

cameroncros commented 2 years ago

Sorry, I misspoke, it's the websocket-client, not requests that is flakey. I will correct my other comment.

SgtKiLLx commented 2 years ago

Sorry, I misspoke, it's the websocket-client, not requests that is flakey. I will correct my other comment.

Any clue as to what needs to be fixed? I kinda miss using this plugin .

cameroncros commented 2 years ago

Best option, upgrade to python3 on your octoprint, and install https://github.com/cameroncros/OctoPrint-DiscordRemote/archive/refs/heads/discordlib.zip

Next best option would be to manually downgrade websocket-client to version 0.57: pip install websocket-client==0.57. This might break other features, so ideally avoid it.

SgtKiLLx commented 2 years ago

Best option, upgrade to python3 on your octoprint, and install https://github.com/cameroncros/OctoPrint-DiscordRemote/archive/refs/heads/discordlib.zip

Next best option would be to manually downgrade websocket-client to version 0.57: pip install websocket-client==0.57. This might break other features, so ideally avoid it.

Alright. I'll give it a swing tomorrow.