cameroncros / OctoPrint-DiscordRemote

Discord plugin for OctoPrint
MIT License
66 stars 34 forks source link

Print Scheduler Support #208

Closed jneilliii closed 2 years ago

jneilliii commented 2 years ago

Is your feature request related to a problem? Please describe. @SgtKiLLx reached out to me about integrating print scheduler job list functionality for discord remote.

Describe the solution you'd like A new command to list scheduled jobs.

Describe alternatives you've considered n/a

Additional context I was curious as to why there was a need for an API for this to work and attempted a non-API approach for doing this and was wondering if this would work or not? Since I'm not super familiar with the overlying structure of your plugin, I thought this might be a good place to start.

Here's is where I'm at so far, but don't have a Discord server to test with completely, and SgtKiLLx was getting permission denied errors during initial testing.

https://github.com/cameroncros/OctoPrint-DiscordRemote/compare/master...jneilliii:feature/printscheduler?expand=1

cameroncros commented 2 years ago

That looks pretty good, i will check it out and try it

SgtKiLLx commented 2 years ago

That looks pretty good, i will check it out and try it

I see it works. Will there be an update pushed soon?

cameroncros commented 2 years ago

Just gotta get a small fix in, and once merged, should be released rapidly afterwards.

On Thu, 18 Nov 2021, 11:40 pm SgtKiLLx, @.***> wrote:

That looks pretty good, i will check it out and try it

I see it works. Will there be an update pushed soon?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/cameroncros/OctoPrint-DiscordRemote/issues/208#issuecomment-972830159, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAK7FL7V6X4WNVORCZ3KDRTUMTX5PANCNFSM5IIPHB4A .

SgtKiLLx commented 2 years ago

@cameroncros , @jneilliii made that fix you mentioned. it works. its perfect. you can merge & push the new release.

cameroncros commented 2 years ago

I'll try do it shortly, but if I run out of time I will have to do it after work. Thanks @jneilliii @SgtKiLLx

jneilliii commented 2 years ago

hold off before merging @cameroncros, I'm going to give a stab at adding the ability to schedule jobs with a bot command as well.

cameroncros commented 2 years ago

Works for me :D Feel free to update the readme and credit yourself if you like as well

jneilliii commented 2 years ago

one quick question, how do the parameters work when sending a command? for example if I need to include a path (may contain spaces) and timestamp along with the /addjob command?

cameroncros commented 2 years ago

Sorry for the delay, I have now merged this to dev, and it will be in the next release. Thanks for the contribution