Closed cameroncros closed 2 years ago
Yeah, the entire code base is bitrotting away because I don't have time to maintain it :( I'll have to fix the broken code eventually when it fail.
On Fri, 19 Nov 2021, 12:04 am jneilliii, @.***> wrote:
Thanks, I was basing the structure on enclosure. I also noticed you're using global api key. That will be going away in favor of application keys. One of the reasons I thought it would be better to not use api calls.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/cameroncros/OctoPrint-DiscordRemote/pull/209#issuecomment-972846560, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAK7FL2OGWNEYFQEOYJHPWLUMT2UJANCNFSM5IJLZTEQ .
Still has issues, can't remove job after adding it:
Also, the removejob function tends to silently swallow a bunch of errors when the arguments don't match correctly, Ideally, they should be handled and return an error message to discord:
Yeah, I wasn't fully finished with the changes. I did have one question here in regard to entering parameters with spaces. The timestamp format is very specific though 2021-11-18 22:00
If I recall correctly, if the timestamp is quoted, it should split the parameters correctly.
On Sat, 20 Nov 2021, 2:25 pm jneilliii, @.***> wrote:
Yeah, I wasn't fully finished with the changes. I did have one question here https://github.com/cameroncros/OctoPrint-DiscordRemote/issues/208#issuecomment-973381755 in regard to entering parameters with spaces. The timestamp format is very specific though 2021-11-18 22:00
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/cameroncros/OctoPrint-DiscordRemote/pull/209#issuecomment-974585011, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAK7FL45KQVWTAPKBIOT3CLUM4ILZANCNFSM5IJLZTEQ .
ok I'll do some additional debugging then because maybe I'm not defining them properly. Couldn't find an example with multiple parameters, only single ones in the existing codebase and SgtKiLLx said it wasn't working to add jobs either. Will need to build a discord server to figure it out though I suppose.
I have a discord server you can use for development, and I can give you the details if you want them.
https://discord.gg/Ws8B7VHc <- If you click that link, you can join the test server, and then I will give you the bot token and channel id so that you can test.
On Sat, 20 Nov 2021, 2:40 pm jneilliii, @.***> wrote:
ok I'll do some additional debugging then because maybe I'm not defining them properly. Couldn't find an example with multiple parameters, only single ones in the existing codebase and SgtKiLLx said it wasn't working to add jobs either. Will need to build a discord server to figure it out though I suppose.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/cameroncros/OctoPrint-DiscordRemote/pull/209#issuecomment-974586445, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAK7FL4EWGK4VKUMRIEBNQLUM4KBJANCNFSM5IJLZTEQ .
no worries, I didn't realize it was that easy to setup. I was able to get it to work but had to rearrange the parameters basically because nothing I tried would allow spaces. Not that big of a deal though.
Thanks, I was basing the structure on enclosure. I also noticed you're using global api key. That will be going away in favor of application keys. One of the reasons I thought it would be better to not use api calls.