cameroncros / OctoPrint-DiscordRemote

Discord plugin for OctoPrint
MIT License
66 stars 34 forks source link

Be able to send mentions into the channel #254

Closed prot0-type closed 10 months ago

prot0-type commented 10 months ago

Is your feature request related to a problem? Please describe. Is it possible to make the @mentions work? I went to put my 3d printer thread in mute and received important parts only.

Describe the solution you'd like Make the mentions work, if possible

cameroncros commented 10 months ago

I haven't looked at this lately, but I believe that bots are intentionally not allowed to @mention in embeds.

As things appear to be finally stable, I can look into @mentions again, but I can't promise anything.

On Wed, Aug 16, 2023 at 9:06 AM Prototype7813 @.***> wrote:

Is your feature request related to a problem? Please describe. Is it possible to make the @mentions work? I went to put my 3d printer thread in mute and received important parts only.

Describe the solution you'd like Make the mentions work, if possible

— Reply to this email directly, view it on GitHub https://github.com/cameroncros/OctoPrint-DiscordRemote/issues/254, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAK7FL53M7WAA4YBRVKN3Q3XVP6GVANCNFSM6AAAAAA3RWGAQA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

prot0-type commented 10 months ago

Thank you!

Le mer. 16 août 2023, 6 h 33 a.m., Cameron @.***> a écrit :

I haven't looked at this lately, but I believe that bots are intentionally not allowed to @mention in embeds.

As things appear to be finally stable, I can look into @mentions again, but I can't promise anything.

On Wed, Aug 16, 2023 at 9:06 AM Prototype7813 @.***> wrote:

Is your feature request related to a problem? Please describe. Is it possible to make the @mentions work? I went to put my 3d printer thread in mute and received important parts only.

Describe the solution you'd like Make the mentions work, if possible

— Reply to this email directly, view it on GitHub https://github.com/cameroncros/OctoPrint-DiscordRemote/issues/254, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAK7FL53M7WAA4YBRVKN3Q3XVP6GVANCNFSM6AAAAAA3RWGAQA>

. You are receiving this because you are subscribed to this thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/cameroncros/OctoPrint-DiscordRemote/issues/254#issuecomment-1680360066, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKEWMTLS55KM2QI5RW5HIUDXVSOWDANCNFSM6AAAAAA3RWGAQA . You are receiving this because you authored the thread.Message ID: @.***>

cameroncros commented 10 months ago

Okay, I think mentions should now work. You'll need to add <@433252064324354048> to the message you want to send the mention. Replace the numbers with the user id of the person you want to mention. Let me know if there are any issues.

prot0-type commented 10 months ago

Hi !

It's perfect ! It's working . The only thing is the mention appear in and out of the text area. But it's a minor thing .

image

cameroncros commented 10 months ago

Yup, that's intentional, unfortunately you can't have mentions inside the embed. Annoyingly, it doesn't seem to do the substitution properly in the title of the embed, so it looks a bit ugly.

On Mon, 21 Aug 2023, 12:02 pm Prototype7813, @.***> wrote:

Hi !

It's perfect ! It's working . The only thing is the mention appear in and out of the text area. But it's a minor thing .

[image: image] https://user-images.githubusercontent.com/42559053/261893504-fc8cc495-ee78-469a-9862-80e343c80d55.png

— Reply to this email directly, view it on GitHub https://github.com/cameroncros/OctoPrint-DiscordRemote/issues/254#issuecomment-1685507347, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAK7FLZUVKFBPYBE6QMIWVTXWK6U7ANCNFSM6AAAAAA3RWGAQA . You are receiving this because you commented.Message ID: @.***>

prot0-type commented 10 months ago

At this point , it's working so I will not complain !

We can close this but maybe for improvement, it will be possible to add a field into the discord settings and add a checkbox for the message you want to add the mentions to and like that , it will hide the placeholder into the message.

Again thanks for the fast developpement