Sort dicts by key in force_string

cameronmaske / celery-once

Celery Once allows you to prevent multiple execution and queuing of celery tasks.

https://pypi.python.org/pypi/celery_once/

BSD 2-Clause "Simplified" License

662 stars 90 forks source link

Closed andbortnik closed 6 years ago

andbortnik commented 6 years ago

This closes #58 issue

cameronmaske commented 6 years ago

Hey andbortnik, great find and thanks for the patch (sorry for the delayed reply).

The one suggestion I'd like to implement, in order to make sure the keys as compatible backwards would be to use OrderedDict instead of Tuples.

This will ensure that if any existing keys (and therefore locks) that are in redis, won't be lost by upgrading (unless the bug you noted occurs).

Would you be comfortable making those changes? If not, I will try to get to them when I'm not swamped with work.

andbortnik commented 6 years ago

Hey @cameronmaske, thank you, the comment make sense. I'll try to fix it this week as soon as I have time.

cameronmaske commented 6 years ago

@andbortnik Thanks for this PR, it's now released as 1.3.0. Sorry again for the delay getting around to it!