cameronmaske / celery-once

Celery Once allows you to prevent multiple execution and queuing of celery tasks.
https://pypi.python.org/pypi/celery_once/
BSD 2-Clause "Simplified" License
661 stars 90 forks source link

celery-once and Redlock #76

Closed NicolasLM closed 5 years ago

NicolasLM commented 6 years ago

I hope this issue doesn't come as too pedantic but the README mentions that celery-once uses the Redlock algorithm.

After digging a bit it looks like redis.lock.Lock uses a plain lock on a single instance, whereas Redlock is about using multiple Redis instances in parallel for fault-tolerance.

The confusion probably comes from the fact that both algorithms are presented in the same page in the Redis documentation.

cameronmaske commented 5 years ago

@NicolasLM Totally not pedantic, and good catch. I'll update the docs to reflect this more accurately!

cameronmaske commented 5 years ago

Closed by #87