search

cameronmaske / celery-once

Celery Once allows you to prevent multiple execution and queuing of celery tasks.
https://pypi.python.org/pypi/celery_once/
BSD 2-Clause "Simplified" License
661 stars 90 forks source link

File backend #84

Closed xuhcc closed 5 years ago

xuhcc commented 5 years ago

This backend allows celery-once to use files for locking.

cameronmaske commented 5 years ago

@xuhcc This looks excellent! Thank you for your contribution. Anything more to do on your end, or is this ready for review?

xuhcc commented 5 years ago

@cameronmaske Yes, it's ready for review.

cameronmaske commented 5 years ago

@xuhcc Overall looks great! Could you grant me permission to make some minor changes (naming consistency) by enabling Allow edits from maintainers?

xuhcc commented 5 years ago

Yes, please. I already set the " Allow edits from maintainers." flag

cameronmaske commented 5 years ago

Ah, I think I'm confused on how to make PR changes locally on the git CLI, I'll merge this as is, and do the changes separately for now.

cameronmaske commented 5 years ago

@xuhcc This is live in version 2.1.0. Thanks again for the contribution!