search

cameronterry / dark-matter

A highly opinionated domain mapping plugin for WordPress Networks
Other
11 stars 2 forks source link

Confirmation of class-dm-rest-domains-controller.php PHP 8.1 Compatibility #113

Open cmcandrew opened 3 weeks ago

cmcandrew commented 3 weeks ago

Question of whether this is a false positive?


------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------
 455 | ERROR | Extension 'mysql_' is deprecated since PHP 5.5 and removed since PHP 7.0; Use mysqli instead
 461 | ERROR | Extension 'mysql_' is deprecated since PHP 5.5 and removed since PHP 7.0; Use mysqli instead
------------------------------------------------------------------------------------------------------------
cameronterry commented 3 weeks ago

That would appear to be related to these function calls in the REST API:

https://github.com/cameronterry/dark-matter/blob/349538e85d8ca3415802220ec2787478dc04cbf0/domain-mapping/rest/class-dm-rest-domains-controller.php#L452-L462

Then yes, I believe they are false positives.

As the mysql_to_rfc3339() is part of WordPress Core: https://developer.wordpress.org/reference/functions/mysql_to_rfc3339/