cameronterry / dark-matter

A highly opinionated domain mapping plugin for WordPress Networks
Other
12 stars 2 forks source link

"Too many redirects" issue when accessing a HTTPS admin on HTTP #20

Closed cameronterry closed 7 years ago

cameronterry commented 7 years ago

Redirect is fine but it should be once ... from HTTP to HTTPS. This is occurring on my own personal Dark Matter test site at Linode.

Chrome Dev Tools > Network with "Preserve Log" checked screenshot below. It is constantly redirecting between HTTP / HTTPS and weirdly ... between [domain]/dark-matter/wp-admin/ and [domain]/dark-matter/dark-matter/wp-admin/.

image

cameronterry commented 7 years ago

Likely introduced somewhere in this commit - https://github.com/cameronterry/dark-matter/commit/7c3fe58d809dd1ff65a642a9b4bb99c9aded9a98 - for 1.0.0 Release Candidate 4.

cameronterry commented 7 years ago

There is a slim chance that this fix for a bug introduced by #19 work, may actually resolve this issue as well... https://github.com/cameronterry/dark-matter/commit/a59e9ab6d8331a146b4d6950d77100db1503988d.

Needs to be tested though.

cameronterry commented 7 years ago

I think the weird domain redirecting is the real cause here but will need to test between HTTP and HTTPS (like the screenshot) to make sure.

cameronterry commented 7 years ago

Nope, the previous fixes have not resolved this issue.