search

camfindlay / silverstripe-twofactorauth

Enable two factor authentication (Timed One-Time Password) for SilverStripe CMS using QR codes.
Other
5 stars 10 forks source link

Generate initial token if configured to not regenerate on Has2FA change #17

Closed micschk closed 7 years ago

micschk commented 7 years ago

Not too sure about the point where this should happen; updateCMSFields may not get called based upon implementation. populateDefaults() only gets called for new records (and would need a write action as well for the TOTP token to persist). requireDefaultRecords() would get called upon build, but not for newly created members. Hence the decision to implement on updateCMSFields. FIX: #13

camfindlay commented 7 years ago

Can you add something to the Configuration docs that explains when you might want to turn this on or off and the effect it has for the end user. See https://github.com/camfindlay/silverstripe-twofactorauth/blob/master/docs/en/configuration.md

micschk commented 7 years ago

Un-closing (reopening) as closing this was unnecessary.

camfindlay commented 7 years ago

Couple of things to close out before merge

micschk commented 7 years ago

I've continued work on this to provide a CMS implementation as well, this PR may be replaced by #23

camfindlay commented 7 years ago

@micschk when you say "may be replaced by #23" do you mean I can close and ignore this PR in favour of that one? (In which case... we can close this one.)

micschk commented 7 years ago

Yes, we van close this one

Op 21 jun. 2017 7:34 a.m. schreef "Cam Findlay" notifications@github.com:

@micschk https://github.com/micschk when you say "may be replaced by #23 https://github.com/camfindlay/silverstripe-twofactorauth/pull/23" do you mean I can close and ignore this PR in favour of that one? (In which case... we can close this one.)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/camfindlay/silverstripe-twofactorauth/pull/17#issuecomment-309968218, or mute the thread https://github.com/notifications/unsubscribe-auth/AA9ZophzDIj5wn4P1J5UKQck2i3gcD-mks5sGKtzgaJpZM4N9-ce .