search

camfort / fortran-src

Fortran parsing and static analysis infrastructure
https://hackage.haskell.org/package/fortran-src
Other
48 stars 20 forks source link

Why is renaming under `Analysis` and not `Transformation`? #279

Open dorchard opened 1 year ago

dorchard commented 1 year ago

I've noticed that the renaming/freshening pass is part of the Analysis submodule: https://github.com/camfort/fortran-src/blob/94248231fd0eedf1fffb46582a3687e85ecaa58a/src/Language/Fortran/Analysis/Renaming.hs#L214

But doesn't it make sense for this to go in Transformation instead since this pertains to basic syntax transformations applied after parsing (like the grouping transformation)?

dorchard commented 1 year ago

Happy to make this change if other people agree, or leave it if someone's got a good reason why it should live here.