Update setup_script to fetch landing page

camicroscope / Caracal

Conslidated Backend, Auth, and Security Services for caMicroscope

GNU General Public License v3.0

15 stars 94 forks source link

Update setup_script to fetch landing page #101

Closed siddhanth339 closed 3 years ago

siddhanth339 commented 3 years ago

Summary

The setup_script was updated to include all the required files to run the application smoothly using node.

Motivation

Testing

It has been tested manually on my local system

birm commented 3 years ago

Since backup-dev is currently holding @YashKumarVerma 's work, I'd appreciate their input here too.

YashKumarVerma commented 3 years ago

Sure, I'll go through this

siddhanth339 commented 3 years ago

Thanks for your time!

YashKumarVerma commented 3 years ago

A pull request (#98) was submitted resolving the issue (#96) before this pull request was sent.

I'm a bit confused on this part:

Should I redirect that PR to @siddhanth339's branch?
Or would this PR be merged after #98 is merged?
Or should #98 be closed

@birm

Thanks !

birm commented 3 years ago

Ah, this must be a peril of messing with commit history. None of the commits in this PR changed matching #98, but the changes are part of this anyway. I think it's resolved.

I'll do a fair bit more testing before merging backup-dev in, but I think this is good to go. Any objections?

siddhanth339 commented 3 years ago

None from my side!

siddhanth339 commented 3 years ago

Thanks!!