search

camicroscope / Caracal

Conslidated Backend, Auth, and Security Services for caMicroscope
GNU General Public License v3.0
15 stars 94 forks source link

data is never defined #116

Closed YashKumarVerma closed 1 year ago

YashKumarVerma commented 3 years ago

https://github.com/camicroscope/Caracal/blob/91fec6d581a2e54e85faeb053511c2df55b49053/handlers/authHandlers.js#L152-L156

birm commented 3 years ago

Data is x, the result of the user function, right?

YashKumarVerma commented 3 years ago

yep that's the value it takes, but the variable itself is never defined with var/let/const.

Just documenting the fixes that I'll be pushing in the PR

Inkster6868 commented 1 year ago

hey is this issue still open? if yes, please assign this to me

birm commented 1 year ago

I think the fix to this is just to change line 152 from data = x; to let data = x;. If you want to submit that as a PR, please do so from and against the 'develop' branch.

VishalMyla commented 1 year ago

Please Assign this issue to me

birm commented 1 year ago

This was fixed in #153