camicroscope / Caracal

Conslidated Backend, Auth, and Security Services for caMicroscope
GNU General Public License v3.0
15 stars 94 forks source link

Integrate Logging Library #76

Open YashKumarVerma opened 3 years ago

YashKumarVerma commented 3 years ago

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

Describe alternatives you've considered

Additional context

birm commented 3 years ago

I think you've given the wrong link to distro. The statement on disabled logging is no longer accurate. I've just updated it in development. In short, it turns out that very few people had concerns about PHI in the logs, but people did have issues with the mongo service (usually) not working without any hints.

Anyway, to the topic of your actual request: I think improving logs, with or without middleware, is a good idea. We'll certainly open a reasonable PR about that on this repo. Thank you for the suggestion in any case!

YashKumarVerma commented 3 years ago

thanks for the detailed answer! just fixed the link 🤦🏼

I'm interested in working on this as I'd be able to understand the codebase better. Could I?

YashKumarVerma commented 3 years ago

@birm ping 👀

birm commented 3 years ago

Of course! I may or may not be picky on the PR, but we'll always welcome improvements! Thank you for your interest.

Parth-Thummar commented 3 years ago

Can I implement logger module with singleton design pattern and create separate function to log different errors and info logs?