camicroscope / Caracal

Conslidated Backend, Auth, and Security Services for caMicroscope
GNU General Public License v3.0
15 stars 94 forks source link

Bugs related to accessing undefined values in dev-backup branch #96

Closed siddhanth339 closed 3 years ago

siddhanth339 commented 3 years ago

Describe the bug When I run the application using docker-compose with Caracal (develop branch), caMicroscope, and Distro repos, I get errors based on accessing undefined values from the /Caracal/service/database/connector.js and the /Caracal/handlers/dataTransformationHandler.js files

To Reproduce Steps to reproduce the behavior:

  1. Run docker-compose -f develop.yml build
  2. Then, run docker-compose -f develop.yml up
  3. See the errors

Expected behavior Run the application smoothly without any errors.

Screenshots

error-undefined

lengthUndefined

System Information:

Device: LENOVO_MT_81DE_BU_idea_FM_ideapad 330-15IKB Processor: Intel(R) Core(TM) i5-8250U CPU @ 1.60GHz, 1800 Mhz, 4 Core(s), 8 Logical Processor(s) OS: Microsoft Windows 10 Home Browser: Chrome Version: 10.0.19041 Build 19041

Additional context I suspect that these errors are due to lots of callback functions. The values of variables are being accessed outside the callback functions which are asynchronous, this being the main cause. Files to look into:

birm commented 3 years ago

Does the master branch of caracal build and work ok for you?

siddhanth339 commented 3 years ago

Yes

siddhanth339 commented 3 years ago

Problem is with the develop branch

YashKumarVerma commented 3 years ago

for anyone who's following this: the code for the said issue is in dev-backup branch

YashKumarVerma commented 3 years ago

@Brim were you able to reproduce anything similar during the time of #90 ? Strange that I did not face this issue, I'll try doing a fresh setup and let you know what I find.

YashKumarVerma commented 3 years ago

update: I was able to reproduce the issue on a fresh setup

YashKumarVerma commented 3 years ago

I believe this can be closed now.