search

camicroscope / caMicroscope

Digital pathology image viewer with support for human/machine generated annotations and markups.
BSD 3-Clause "New" or "Revised" License
255 stars 295 forks source link

Added aria-label to toolbar icons #1010

Closed nwanduka closed 4 months ago

nwanduka commented 4 months ago

Summary

This PR fixes #981

Motivation

Testing

Questions

birm commented 4 months ago

I don't seem to actually see the aria labels on the rendered toolbar items.

nwanduka commented 4 months ago

I don't think I understand what you mean. Are you saying you can't "see" the aria-label or when testing with a screen reader, the aria-label isn't called out?

Also could you tell me how you're viewing the changes made? I'd like to be able to confirm that any changes I made work as intended before creating a PR. I don't know how to. Or you could point me to a resource material. Any would be helpful.

birm commented 4 months ago

The issue that I noticed is that the html for the toolbar icons wasn't including the aria label. I think I've added it in 6dafdf6; please let me know if you agree or not :)

nwanduka commented 4 months ago

Ohhhkay. I get it. I missed that. Thanks for pointing it out. And fixing it 😊

birm commented 4 months ago

Does it look ok to merge to you?

nwanduka commented 4 months ago

Yes, looks good to me. Ready to merge.