search

camicroscope / caMicroscope

Digital pathology image viewer with support for human/machine generated annotations and markups.
BSD 3-Clause "New" or "Revised" License
255 stars 295 forks source link

[Accessibility] Workbench: Back button unresponsive to 'enter' key #1022

Closed nwanduka closed 3 months ago

nwanduka commented 3 months ago

Describe the bug The back button on the workbench page can receive keyboard focus when tabbing through the page. However, when the button has focus and the Enter key is pressed, it does not perform its expected action of returning to the previous page. This issue impacts keyboard accessibility, as users who rely on keyboard navigation cannot use the back button functionality.

To Reproduce Steps to reproduce the behavior:

  1. Navigate to the workbench page
  2. Use the Tab key to move focus to the back button
  3. Press the Enter key

Expected behavior Pressing Enter should activate the back button, returning the user to the previous page.

Suggested investigation Check the event listener for the Enter key press on the back button. Verify that the button's onClick event (or equivalent) is properly set up for keyboard interactions.

Additional context The focus visibility of the button has been fixed in a previous update. This issue specifically relates to the button's lack of response to the Enter key.

YashrajKupekar17 commented 3 months ago

I would like to solve this issue. Please assign it to me.

birm commented 3 months ago

Hi @YashrajKupekar17; just a reminder that we don't typically assign issues to people. If we did, we'd have a lot of orphaned issues/PRs. If you want to work on something, work on something and submit a PR! Some guidance for contributors is collected at http://camicroscope.org/contributing.html ; please let us know in a new issue if you think it's unclear!

That said, the [accessibility] issues raised by @nwanduka are much more likely to also be completed by them, as they're participating in an open source internship.