Open rajku-dev opened 1 week ago
Thanks for jumping in to fix this @rajku-dev. Well done. While we wait for @birm to review the changes, could you change the base branch from master
to develop
? And for subsequent PRs, develop
should be the base branch.
Thanks for jumping in to fix this @rajku-dev. Well done. While we wait for @birm to review the changes, could you change the base branch from
master
todevelop
? And for subsequent PRs,develop
should be the base branch.
I've updated the base branch to develop
as requested. Let me know if there's anything else I need to adjust
Hi @birm, I hope you are doing well Can you please review the changes on my recent PRs fixing two bugs, and decide whether they can be merged or not.
Fixes #994
Explanation of Changes
interactive: true
: Keeps the tooltip open when hovering over the tooltip itself, so it doesn't disappear immediately. This fixes the issue where the tooltip would disappear before users can interact with it.trigger: 'mouseenter focus'
: Ensures the tooltip activates on both mouse hover and keyboard focus, making it accessible for keyboard users and screen readers.aria
configuration: Settingaria: { content: 'describedby' }
links the tooltip to the label for screen readers, providing a description of the label's purpose.This configuration help ensure tooltip remains visible when needed and is fully accessible for all users, including those who rely on screen readers.