search

camicroscope / caMicroscope

Digital pathology image viewer with support for human/machine generated annotations and markups.
BSD 3-Clause "New" or "Revised" License
247 stars 286 forks source link

Fixed disabled in mobile view #830 #854

Closed Ayesh-07 closed 5 months ago

Ayesh-07 commented 5 months ago

Fixed disabled in mobile view #830

Summary

Remove the user-scalable="no" parameter from the content attribute to allow zooming. Add maximum-scale=2.0 for ensuring that the maximum-scale parameter is not less than 2 to allow sufficient zooming.

By removing the user-scalable="no" parameter and ensuring the maximum-scale parameter is set appropriately, users will be able to zoom in and out on the Info Page in mobile view, improving accessibility for people with low vision.

Motivation

I'm passionate about contributing to the caMicroscope organization to further my skills and knowledge. One of the issues I've successfully fixed is #830, which involved addressing the disabled zooming on the mobile view of the Info Page. I would appreciate a review of my work to ensure it meets the project's standards. This experience has deepened my understanding of user-centered design and my ability to create intuitive user interfaces.

birm commented 5 months ago

Out of curiosity, why just info.html?

Ayesh-07 commented 5 months ago

Out of curiosity, why just info.html?

@birm I focused on Info.html because that's where I first noticed the problem with zooming on mobile view. The issue is that users are unable to zoom in or out on the table in mobile view, which is critical for viewing the entire table content. If you need me to look into other pages, please let me know.

nwanduka commented 5 months ago

Thank you @Ayesh-07 for this. I checked the other pages and noticed the issue is also present in the Slides and Signup pages. I fixed them in this PR.