camicroscope / caMicroscope

Digital pathology image viewer with support for human/machine generated annotations and markups.
BSD 3-Clause "New" or "Revised" License
255 stars 295 forks source link

Created GH workflow for accessibility checks #957

Closed nwanduka closed 6 months ago

nwanduka commented 7 months ago

Summary

Motivation

Testing

Questions

birm commented 7 months ago

Since caMicroscope is already in raw html/js form, we typically just use a http server to host it (see https://github.com/camicroscope/caMicroscope/blob/55d8db226ad28daa9908d00142fbbae4c61812e0/.github/workflows/node.js.yml#L30)

hope this helps!

nwanduka commented 7 months ago

Since caMicroscope is already in raw html/js form, we typically just use a http server to host it (see

https://github.com/camicroscope/caMicroscope/blob/55d8db226ad28daa9908d00142fbbae4c61812e0/.github/workflows/node.js.yml#L30

) hope this helps!

It does help a lot. Thank you so much for the tip. Now I'm past the start script error. There's a challenge though when it starts to run the axe core CLI. It can't find the server hosting the application. I'll try to debug this on my own but if the issue persists, I'll be sure to reach out again.

nwanduka commented 7 months ago

After two (may have been more) weeks and 17 commits, I'm thrilled to announce that I've finally had a breakthrough with this task. The workflow works!!! 🤗

image

@birm for your review. I also want to confirm that I'm using the right port. I had been using localhost/4010 and kept encountering errors. So I used this: https://github.com/camicroscope/caMicroscope/blob/55d8db226ad28daa9908d00142fbbae4c61812e0/test/config.js#L4

birm commented 6 months ago

This is great! We'll have some test failures until we get them resolved, but fantastic work!

nwanduka commented 6 months ago

This is great! We'll have some test failures until we get them resolved, but fantastic work!

Thank you @birm 😊. And thanks again for your support!!!!!