camicroscope / caMicroscope

Digital pathology image viewer with support for human/machine generated annotations and markups.
BSD 3-Clause "New" or "Revised" License
256 stars 295 forks source link

Added pa11y and lighthouse a11y testing to workflows #991

Open nwanduka opened 4 months ago

nwanduka commented 4 months ago

Summary

Created pa11y.yml and lighthouse.yml to complement the already existing axe a11y testing tool in workflows

Motivation

Testing

Questions

birm commented 4 months ago

Am I reading the lighthouse report correctly that it seems to be stuck at the redirect?

nwanduka commented 4 months ago

Am I reading the lighthouse report correctly that it seems to be stuck at the redirect?

Yep! That's the issue I meant when I said it wasn't testing all the pages. I wonder why that is.

birm commented 4 months ago

It looks like it's not following links or anything of the sort. Do we need to give it a list of urls?

nwanduka commented 4 months ago

No, I don't think we need to provide it with a list of URLs. According to the docs, Lighthouse will "automatically find your project's static assets, run Lighthouse 3 times on each HTML file, and upload the reports to temporary public storage where they'll be accessible to anyone with the URL."

github-actions[bot] commented 2 days ago

This PR is stale because it has been open 45 days with no activity.