camilb / prometheus-kubernetes

Monitoring Kubernetes clusters on AWS, GCP and Azure using Prometheus Operator and Grafana
Apache License 2.0
670 stars 299 forks source link

update default to latest stable version #101

Closed ArchiFleKs closed 6 years ago

drubin commented 6 years ago

Does this not require a bunch of rbac rules? I tried this and it didn't seem to work out the box. (Or is the only change #102)

ArchiFleKs commented 6 years ago

@drubin Hi, I tried with the version from this PR and the only issue I had was with the RBAC fixed in the #102

drubin commented 6 years ago

@ArchiFleKs Maybe we should combine these two PR's then if they are actually linked?

I tried them and I was missing all my alerts/rules, I can maybe try upgrading to these versions.

What is the recommended approach for "upgrading" components with this tool? just edit the numbers and deploy again? (This part feels a little clunky right now)

camilb commented 6 years ago

@ArchiFleKs @drubin Will merge this and push a fix for alert rules later

camilb commented 6 years ago

@ArchiFleKs @drubin Fixed rules in #108