search

camino-rs / camino

Like Rust's std::path::Path, but UTF-8.
https://docs.rs/camino
Apache License 2.0
435 stars 16 forks source link

Restrict when `try_reserve_2` is enabled #23

Closed smoelius closed 2 years ago

smoelius commented 2 years ago

Ref: https://github.com/camino-rs/camino/pull/21#issuecomment-1212597255

If you decide this PR is too invasive, I won't be insulted if you close it without merging.

sunshowers commented 2 years ago

Thanks. This looks fine except it pulls in a couple extra dependencies. Can those dependencies be inlined as with the current implementation?

sunshowers commented 2 years ago

(My concern is that those dependencies may have their own MSRVs now or in the future—currently, camino is a zero-dep library by default.)

sunshowers commented 2 years ago

Apologies, one more change: could this just do "stable/beta 1.64 or later, nightly 1.65 or later"? That means we can avoid the date-parsing code.

smoelius commented 2 years ago

Apologies, one more change: could this just do "stable/beta 1.64 or later, nightly 1.65 or later"? That means we can avoid the date-parsing code.

What do you think the CI toolchains should be in this case?

sunshowers commented 2 years ago

I'd just pick the nightly before the feature was stabilized (and add a comment to CI explaining this)

sunshowers commented 2 years ago

Thanks, going to land this and get a new version out after it passes CI.

smoelius commented 2 years ago

Thanks for being so accommodating!