camlab-bioml / cytomarker

Interactive design and validation of antibody panels using single-cell atlases
https://camlab.shinyapps.io/cytomarker/
Other
2 stars 0 forks source link

App crashes using seurat object as dataset #95

Closed Michael-Geuenich closed 1 year ago

Michael-Geuenich commented 2 years ago

I've tried uploading the scRNAseq_longitudinal_LCMV_Arm_Cl13.Rds dataset from here: https://www.dropbox.com/sh/0b0zb0xd6ycxn0y/AAAQsL0yZ9kfAcOmwodN4QhFa?dl=0

The app crashes before I can select any assay or cell type column with the following error:

Listening on http://127.0.0.1:5117
Warning: Error in <Anonymous>: unable to find an inherited method for function ‘assays’ for signature ‘"character"’
  3: runApp
  2: print.shiny.appobj
  1: <Anonymous>

This might be an issue with the functions in sccwiz though

matt-sd-watson commented 1 year ago

For this object is looks like all of the gene names are lowercase:

head(rownames(long_sce))
Mrpl15 Lypla1 Gm37988 Tcea1 Atp6v1h Rb1cc1

so likely the gene parsing functions are returning no hits from annotables. We may want to build in a check for capitalization of gene symbols.

when i convert the row names to uppercase it is able to run.

kieranrcampbell commented 1 year ago

lower case is almost always mouse, is this dataset definitely human?

Michael-Geuenich commented 1 year ago

Oh, good point. This is a mouse dataset - I just forgot that we don't support mouse yet

kieranrcampbell commented 1 year ago

can we add functionality that throws an error if the genes are lowercase? ("Looks like your dataset is mouse but we don't support this yet")