search

camlost2 / AJE

Advanced Jet Engine for KSP
8 stars 10 forks source link

TPRCurves have weird kinks in them #26

Closed blowfishpro closed 9 years ago

blowfishpro commented 9 years ago

Setting all the tangents to zero makes them somewhat less than smooth. Could just adjust the tangents until they look smooth, but if they're based on actual data somewhere then that should be used.

NathanKell commented 9 years ago

The J58's TPRCurve is based--in its points--on the best info I could glean. No idea about the slope, it was supposed to just be flat until the start of decrease, linear to end of decrease, flat again. I'll pop it into Unity and fix.

blowfishpro commented 9 years ago

This is what I'm talking about:

ajetprcurves

Near the control points, the TPR curves are flat (because their tangents are zero), but this makes them somewhat less than smooth.

NathanKell commented 9 years ago

Ah, crap, right, misread and thought you were talking about the engine curves. Yeah, these need to be fixed.

blowfishpro commented 9 years ago

ajetprcurves

Thanks, looks much better now.