search

camlost2 / AJE

Advanced Jet Engine for KSP
8 stars 10 forks source link

Critical error from ModuleEnginesAJERotor #53

Closed DracheTek closed 8 years ago

DracheTek commented 8 years ago

There is a critical bug from ModuleEnginesAJERotor

Reproduction: in flight, shut down a part with ModuleEnginesAJERotor by pull the throttle to a full zero.

What does not reproduce: If the craft is originally landed, I can pull the throttle down to zero. Once it lifted off and landed again I can not pull the throttle to zero. switching off by action menu is safe, whether it is in flight or not. The model itself have no problem. I tried by comment out the item in AJE config file. Other models using AJE Rotor setting are also broken, namely VTOL engine from Firespitter.

The game refer it as NullReferenceError.

blowfishpro commented 8 years ago

I see a lot of NREs from Firespitter, but there's not much I can do about those. I was able to get an error by throttling to zero - the screen turns black and the debug output spams "Look rotation viewing vector is zero" - is that what happened to you? This is usually caused by NaN or infinite forces being applied. If so, I'll look into whether it's AJE which is causing this.

DracheTek commented 8 years ago

Yes it is what I have encountered.

blowfishpro commented 8 years ago

For reference, the issue was that when throttled down to zero, the SAS multiplier became NaN, so the reaction wheel was giving NaN torque.