search

camomile-project / camomile-server

Collaborative annotation of multimedia documents
http://camomile-project.github.io/
MIT License
12 stars 4 forks source link

CORS and multiple origin #76

Open rom1504 opened 7 years ago

rom1504 commented 7 years ago

I've been having a problem in camomile-polymer-client when accessing the server from a second origin. It seems the browser remembers the first origin, which then doesn't match the Access-Control-Allow-Origin header.

I believe this is related to that line of code https://github.com/camomile-project/camomile-server/blob/e7625eecd2320198f2f133baeb51928406f9dcad/app.js#L147

https://www.npmjs.com/package/cors#configuration-options explains the available options for cors

It might be possible to change something there to make it work for several origin.

hbredin commented 7 years ago

Hmmmmm. Strange. Isn't it a problem with the JavaScript client, then?

hbredin commented 7 years ago

Shouldn't we also reset the cookie here:

https://github.com/camomile-project/camomile-client-javascript/blob/master/index.js#L155

rom1504 commented 7 years ago

The master branch of camomile-client-javascript isn't up to date, the develop branch is up to date. It might be a problem in the javascript client but there's nothing mentioning the origin so I'm not sure. Maybe something inside the http api used in the client is sending the previous origin by default.