campDevs / DiscordBot

Discord bot.

https://glitch.com/edit/#!/carnelian-crayfish

MIT License

73 stars 19 forks source link

Add eslint, eslint-common, prettier + precommit hook. Resolves #103 #109

Closed kraftman closed 5 years ago

kraftman commented 5 years ago

Resolves

Resolves #103

Changes

Added eslint and prettier
Added precommit hook so they both run on commit
Added prettier-eslint which prevents eslint --fix and prettier clashing with each other
Added helper scripts for the initial run of both eslint and prettier across the codebase

Notes: You may want to tweak the prettier config slightly or use a different eslint configuration. let me know

glynnw commented 5 years ago

Am I missing something or did you leave out husky and lint-staged from the dev dependencies? Also, we're still deciding on what style we're going to go with. I started it off without semis so for now I don't see any harm with leaving standard style, but from what I've gathered we'll likely go to something with semicolons at some point.

kraftman commented 5 years ago

Am I missing something or did you leave out husky and lint-staged from the dev dependencies? Also, we're still deciding on what style we're going to go with. I started it off without semis so for now I don't see any harm with leaving standard style, but from what I've gathered we'll likely go to something with semicolons at some point.

My bad. Updated and tested, I'll leave this open for amendment when you decide what styling options you want to go with

glynnw commented 5 years ago

Merged manually