search

campagnola / pyabc

Python library for parsing and analyzing ABC music notation
MIT License
20 stars 11 forks source link

Problem parsing some keys #7

Closed grennis closed 6 years ago

grennis commented 6 years ago

Hi, there seems to be a bug parsing some keys. For example, key of Db major. This line of code:

https://github.com/campagnola/pyabc/blob/master/pyabc.py#L152

Will convert keys to ionian, but also has the side effect of changing the key from Db to C# (as if it were a pitch). So the accidentals are applied from key C# instead of Db.

campagnola commented 6 years ago

Fixed, but now I'm curious why you closed the issue?

grennis commented 6 years ago

I thought I did not do a good job describing the bug. I was going to re-open a new one with a better description and specific reproduce case, but you have already fixed it. The fix looks good, thanks!