search

campaignmonitor / createsend-python

A Python library for the Campaign Monitor API
http://campaignmonitor.github.io/createsend-python
MIT License
57 stars 63 forks source link

Fix SSL Certificate Validation #15

Closed jdennes closed 11 years ago

jdennes commented 11 years ago

I don't know why this pull request was merged without any test coverage.

Could you add tests? The contributing guidelines exist for very good reasons and apply to everyone who contributes to this repository.

/ping @shennys @richardbremner

richardbremner commented 11 years ago

@jdennes Thanks for your comment. We made this change in response to a security issue and decided the priority was to deliver this fix as soon as possible. Work is ongoing and unit tests will follow soon.

jdennes commented 11 years ago

the priority was to deliver this fix as soon as possible

The fix is delivered when a new version of the library is released, which hasn't happened as part of your work.

jdennes commented 11 years ago

This is addressed by this reimplementation of certificate verification.