Use CGI SERVER_NAME in UA string (fixes #28)

campaignmonitor / createsend-python

A Python library for the Campaign Monitor API

MIT License

57 stars 64 forks source link

Closed SpainTrain closed 7 years ago

SpainTrain commented 7 years ago

Get platform name for user agent string from the standard CGI server env var SERVER_SOFTWARE if present.

This prevents the library from raising an exception on Google App Engine.

Closes #28

This change is

SpainTrain commented 7 years ago

Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

SpainTrain commented 7 years ago

Is it possible to get feedback on this so it can be merged and published? This is required for us to use our Campaign Monitor account. Thanks!

/cc @asadighi @jdennes @philoye @izquierdo

SpainTrain commented 7 years ago

:heart_eyes_cat:

SpainTrain commented 7 years ago

Hello. Is it possible to get this released to pypi? https://pypi.python.org/pypi/createsend/

Thanks again!

jdennes commented 7 years ago

I released 4.2.0 on PyPI. I'm not an active maintainer of this project, so someone from Campaign Monitor should be added as an owner of the package.