search

campaignmonitor / createsend-python

A Python library for the Campaign Monitor API
http://campaignmonitor.github.io/createsend-python
MIT License
57 stars 64 forks source link

Support Unicode when decoding json responses from createsend API #38

Closed bharling closed 7 years ago

bharling commented 7 years ago

This fixes #37

tobio commented 7 years ago

@bharling are you able to include a test case for this issue as well please?

bharling commented 7 years ago

sure - will try and do one today

bharling commented 7 years ago

I'll put in a test case for my specific issue, however this modification affects a very hot code path so I'm not sure whether more tests should be conceived?

tobio commented 7 years ago

Looks good, much appreciated. Definitely room for more complete testing here, but this is pretty clear for these changes.