search

campaignmonitor / createsend-python

A Python library for the Campaign Monitor API
http://campaignmonitor.github.io/createsend-python
MIT License
57 stars 64 forks source link

All imports from __init__.py are now explicit #46

Closed djstein closed 7 years ago

djstein commented 7 years ago

import * which causes a circular issue on install has been removed.

djstein commented 7 years ago

@jdennes Hey man, would be great if we could get a pull from this, it should fix the issue people are having here #45. I emailed Campaign Monitor asking for actual support and relief for you!

jdennes commented 7 years ago

Hm, on current master it looks like there's still an issue when using 2.7 to me, but using 3.6 works fine?

› python --version     
Python 2.7.13

› python setup.py sdist
Traceback (most recent call last):
  File "setup.py", line 3, in <module>
    from createsend.createsend import __version__
  File "/Users/jdennes/projects/campaignmonitor/createsend-python/createsend/__init__.py", line 8, in <module>
    from createsend.utils import (
  File "/Users/jdennes/projects/campaignmonitor/createsend-python/createsend/createsend.py", line 12, in <module>
    from createsend.utils import VerifiedHTTPSConnection, json_to_py, get_faker
ImportError: No module named utils

› python3 --version    
Python 3.6.1

› python3 setup.py sdist
/usr/local/Cellar/python3/3.6.1/Frameworks/Python.framework/Versions/3.6/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'install_requires'
  warnings.warn(msg)
running sdist
running check
reading manifest file 'MANIFEST'
creating createsend-4.2.2
creating createsend-4.2.2/createsend
creating createsend-4.2.2/test
making hard links in createsend-4.2.2...
hard linking setup.py -> createsend-4.2.2
hard linking createsend/__init__.py -> createsend-4.2.2/createsend
hard linking createsend/administrator.py -> createsend-4.2.2/createsend
hard linking createsend/cacert.pem -> createsend-4.2.2/createsend
hard linking createsend/campaign.py -> createsend-4.2.2/createsend
hard linking createsend/client.py -> createsend-4.2.2/createsend
hard linking createsend/createsend.py -> createsend-4.2.2/createsend
hard linking createsend/list.py -> createsend-4.2.2/createsend
hard linking createsend/person.py -> createsend-4.2.2/createsend
hard linking createsend/segment.py -> createsend-4.2.2/createsend
hard linking createsend/subscriber.py -> createsend-4.2.2/createsend
hard linking createsend/template.py -> createsend-4.2.2/createsend
hard linking createsend/transactional.py -> createsend-4.2.2/createsend
hard linking createsend/utils.py -> createsend-4.2.2/createsend
hard linking test/test_administrator.py -> createsend-4.2.2/test
hard linking test/test_authentication.py -> createsend-4.2.2/test
hard linking test/test_campaign.py -> createsend-4.2.2/test
hard linking test/test_client.py -> createsend-4.2.2/test
hard linking test/test_createsend.py -> createsend-4.2.2/test
hard linking test/test_list.py -> createsend-4.2.2/test
hard linking test/test_people.py -> createsend-4.2.2/test
hard linking test/test_segment.py -> createsend-4.2.2/test
hard linking test/test_subscriber.py -> createsend-4.2.2/test
hard linking test/test_template.py -> createsend-4.2.2/test
hard linking test/test_transactional.py -> createsend-4.2.2/test
hard linking test/test_verifiedhttpsconnection.py -> createsend-4.2.2/test
Creating tar archive
removing 'createsend-4.2.2' (and everything under it)