Open riklaunim opened 8 months ago
:+1: For this, we need this merged ASAP too
@henrys-cm or anyone at CM, could you please review this?
This library doesn't work with Python 3.12+, which I assume is reasonably important.
I've tried emailing the support to hopefully get some action on this. One thing that is missing from this PR is it would be good to update tox to test against Python 3.11 and 3.12.
I've tried emailing the support to hopefully get some action on this. One thing that is missing from this PR is it would be good to update tox to test against Python 3.11 and 3.12.
That can be added, although someone with knowledge of the codebase has to look at this. Like those hasattr
I had to use were quite unexpected.
ssl.wrap_socket was deprecated since Python 3.7 and remove in 3.12 so for it to work with 3.12 SSLContext.wrap_socket has to be used.
https://pradyunsg-cpython-lutra-testing.readthedocs.io/en/latest/whatsnew/3.12.html
Tested for my use case and it seems to be working fine, although did not test with self.key_file/self.cert_file set which were undefined (and None in some test).