search

campaignmonitor / magento-extension

Campaign Monitor extension for the Magento E-Commerce Platform
https://www.magentocommerce.com/magento-connect/catalog/product/view/id/30754/s/campaign-monitor/
MIT License
4 stars 7 forks source link

composer.json #8

Open kkrieger85 opened 7 years ago

kkrieger85 commented 7 years ago

Please add composer.json file

toddhainsworth commented 7 years ago

Agreed, this would be fantastic! While using package.xml is perfectly workable, the addition of a composer.json would remove some complexity and workflow adjustment. :+1:

toddhainsworth commented 7 years ago

@kkrieger85 I've just made a PR for this, feel free to add to it as you see fit!

https://github.com/campaignmonitor/magento-extension/pull/10

alexkoepke commented 7 years ago

Hi @DaveOrDead or @nufyoot,

I know @toddhainsworth has already submitted a PR to fix this issue. However, its been open for quite some time and I am hoping this attracts some attention to this issue.

Also the @toddhainsworth PR could cause some issues because it sets the default Magento dir. However, @toddhainsworth did update the readme.md like a champ!

  "extra": {
    "magento-root-dir": "."
  }

I have also submitted PR #11.