search

campaignmonitor / shell

Campaign Monitor's CSS library
MIT License
15 stars 4 forks source link

Review all settings using units #109

Open chris-pearce opened 7 years ago

chris-pearce commented 7 years ago

Defining units on settings makes them really rigid, e.g.:

$shell-g-border-radius: 3px;

https://github.com/campaignmonitor/shell/blob/master/src/_settings.scss#L208

If we wanted a larger radius we can't do:

$shell-g-border-radius-large: $shell-g-border-radius + 1;

Let's review all settings with units.

chris-pearce commented 7 years ago

It seems Sass allows this now.