search

campbellC / third-wheel

A rust implementation of a man-in-the-middle proxy
MIT License
71 stars 19 forks source link

Don't rely on the fork of tokio-tls #7

Closed campbellC closed 4 years ago

campbellC commented 4 years ago

Currently we are using a fork of tokio-tls because of a regression in the alpha version of that library which hides the SSL certificate details from client code. There's an open issue about this on the tokio repo. We could cut the tokio project a PR with something like what the fork does; the current fork isn't great so will need improving. Or we can just wait and hope they get to that issue eventually.

campbellC commented 4 years ago

In the linked tokio issue there seems to have been a PR merged that fixes the issue upstream. This issue should now just be to migrate to the new version of tokio.

campbellC commented 4 years ago

Done