Remove dependency to multipanelfigure. Use gridExtra.

campbio / celda

Bayesian Hierarchical Modeling for Clustering Single Cell Genomic Data

http://bioconductor.org/packages/celda

MIT License

148 stars 27 forks source link

Remove dependency to multipanelfigure. Use gridExtra. #396

Closed zhewa closed 1 year ago

zhewa commented 1 year ago

Hi @joshua-d-campbell,

Can you review this pull request and merge if OK? #395

Thanks

joshua-d-campbell commented 1 year ago

Major thanks @zhewa for fixing this! I really appreciate it! The checks are failing I believe because multipanelfigure is still in the NAMESPACE file. Can you run devtools::document() and update the PRs? Hopefully that will fix it.

joshua-d-campbell commented 1 year ago

I have updated GitHub workflows in another PR so it will pass getting around the error in dbplyr. I will propagate this to master so this PR isn't needed. Thanks again!