campeon23 / split-fetcher

The code is a concurrent file downloader in Go that splits a file into multiple parts, downloads them in parallel, and assembles the final file, with support for Etag validation to ensure file integrity.
MIT License
1 stars 0 forks source link

Logger Initialization Placement #109

Closed campeon23 closed 1 year ago

campeon23 commented 1 year ago
  • Package Name: main
  • Function Name: execute
  • Line Code: Between 197-198

Description: Logger is initialized inside the execute function. This should ideally be initialized at the package level or in the main function to ensure it's available for all functions and scenarios.

Severity: Moderate

campeon23 commented 1 year ago

Issue Closure Comment:

Regarding the concern raised for the execute function in the main package (lines 197-198) about the logger initialization: I have made the necessary changes in the recent commit:

Given these adjustments, I believe this addresses the issue raised. I'm closing this issue now. Please review the changes and let me know if there are any further concerns.