campeon23 / split-fetcher

The code is a concurrent file downloader in Go that splits a file into multiple parts, downloads them in parallel, and assembles the final file, with support for Etag validation to ensure file integrity.
MIT License
1 stars 0 forks source link

Return a Message Instead of Printing in DownloadPartFiles() Function #116

Open campeon23 opened 1 year ago

campeon23 commented 1 year ago

Package/File: downloader.go

Function: DownloadPartFiles()

Line Code: 466

Description:

In the DownloadPartFiles() function, we currently print the message "No errors received from goroutine" directly to the console. For better manageability and consistency, it would be more appropriate to return this as either a message or an error instead of printing it.

Recommended Solution:

Remove the fmt.Println("No errors received from goroutine") statement. Replace it with a return statement that returns the message as an error or a dedicated message type (based on the current function's return type and the broader architecture's design patterns).

Example:


if ok {
    return fmt.Errorf("No errors received from goroutine")
}

OR

if ok {
    return nil, "No errors received from goroutine"
}

(Note: The exact implementation will depend on the existing function's signature and expected return values.)

This change will allow the calling function or the higher-level logic to decide how to handle or display this message, offering more flexibility and better adherence to best practices.

Priority: Medium (Adjust as necessary based on your project's needs)