search

campoy / embedmd

embedmd: embed code into markdown and keep everything in sync
Apache License 2.0
767 stars 62 forks source link

Unable to match escaped forward-slashes #44

Closed bbrks closed 7 years ago

bbrks commented 7 years ago

I want to match between a set of multi-line C-style (/* */) style comments which get displayed at the package level in the godoc tool. For example: doc.go source -> godoc preview

But I get an unbalanced / error when trying to escape values with the regexps: /\/\*/ or /\*\//

I'd imagine this would also cause issues when attempting to match a file path, or URL.

campoy commented 7 years ago

Thanks for the issue, I disagree on your fix (see the comments on the PR) but I agree this should be fixed 👍

bbrks commented 7 years ago

I've addressed your comments, thanks!