campoy / jsonenums

This tool is similar to golang.org/x/tools/cmd/stringer but generates MarshalJSON and UnmarshalJSON methods.
Apache License 2.0
490 stars 57 forks source link

Update comment so generated files can be automatically recognized #30

Closed ericwilson29 closed 4 years ago

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
ericwilson29 commented 6 years ago

I signed it!

googlebot commented 6 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

googlebot commented 6 years ago

CLAs look good, thanks!

pauleyj commented 6 years ago

this looks good to me, any reason not to merge?

suhaibmujahid commented 4 years ago

It looks good, why this is not merged?

scorsi commented 4 years ago

@campoy can you please merge that PR ? Thanks !

suhaibmujahid commented 4 years ago

@campoy :)