Closed Tibonium closed 9 years ago
That is an excellent question; clearly something that we missed.
I was confused at first because I forgot that _source is a reference to source_params and that _receiver is a reference to _receiver_params.
Here are my notes from this morning discussion of a long term solution.
Re-reading the EVA spec indicates that
So should the "frequencies" part of the wavefront be the intersection of every frequency band of the "targets" and the "source"? And then when the eigenrays are passed to the pair, we cherry-pick the intensities and phases that are valid for this pair?
The wavefront will only knows the frequencies for one sensor. The sensor_pair starts with a copy of the source frequencies, but then deletes frequencies that are out of the receiver ban. That trimming should effect the sensor_pair's fathometers and envelopes, but not the sensor_model's eigenrays and eigenverbs.
I believe we have found out that the above comment is actually in reverse? The source frequencies are clipped to the receiver?
Based on the emails with John P. today, the source frequencies should be clipped to the receiver.
Pull Request #173 Relocate Frequencies closes all the following:
When a sensor receives an update it then calls run_wave_generator() and within this call it creates a wavefront and propagates it. At this time, the sensor passes in the _source->frequencies() as the wavefront frequencies. What happens for the following:
1) _source is not defined, ie the sensor is a receiver only 2) when the sensor is a receiver only what are the correct frequencies to use for propagation?