search

camptocamp / c2c.recipe.closurecompile

A buildout recipe to compile javascript with the Google Closure Compiler
MIT License
2 stars 3 forks source link

Adding error handling when Closure Compiler fails. #5

Closed gjn closed 11 years ago

gjn commented 11 years ago

When Closure compiler failed, there was no error in the buildout and the result was an empty file. This pull request will add error handling and output the error to the console.

Would be nice if you could integrate this and publish it on PyPi.

Maybe it will also worth it to update to latest version of depswriter and other google related code. I can do it; just let me know if it's worth it.

jeg

gjn commented 11 years ago

Just added the newest source from google subversion repository. I tested it with our application and it works. Both depswriter as well as compiler component were tested. For compiler, all 'level' settings and all 'output_mode' settings were tested and are working as before.

fredj commented 11 years ago

Looks good, thanks. Can you please also update the version in setup.py ('0.3.1' to '0.3.2') ?

fredj commented 11 years ago

New version uploaded to pypi: http://pypi.python.org/pypi/c2c.recipe.closurecompile/0.3.2

Thanks for contributing!

gjn commented 11 years ago

Great.

Thanks for integrating this fast.