camptocamp / c2cgeoportal

c2cgeoportal application
http://geomapfish.org
Other
64 stars 46 forks source link

package.json points to master branches of ngeo and openlayers #3089

Closed romanzoller closed 7 years ago

romanzoller commented 7 years ago

Project:

The package.json in this project points to master versions of ngeo and openlayers, which leads to all sorts of trouble, e.g. some step in the build is trying to access closure-util inside openlayers, which no longer exists there.

The file has been committed to schwyz_geoportal in a commit (https://github.com/camptocamp/schwyz_geoportal/commit/ca44e76f3bced9bc56a0a05a2efedd180cfd368d) that says "Upgrade to GeoMapFish 1.6.7". Indeed, the 1.6 branch of c2cgeoportal still seems to point to master of ngeo and openlayers, which is a bug IMHO:

https://github.com/camptocamp/c2cgeoportal/blob/d6ae1714950294372459b43cee0aefc5fd3be992/c2cgeoportal/scaffolds/create/package.json#L19-L21

romanzoller commented 7 years ago

Comment from @sbrunner: gmf 1.6 should not be doing npm install anyway, so this shouldn't be an issue. Update: there is no npm install, but an attempt to access the openlayers folder anyway, see #3091