camptocamp / c2cgeoportal

c2cgeoportal application
http://geomapfish.org
Other
64 stars 46 forks source link

forward_headers is allowed in checker sub sections but readed from checker section #3127

Closed arnaud-morvan closed 6 years ago

arnaud-morvan commented 7 years ago

Project: aeroportdelyon_sig

In section 'checker' in https://github.com/camptocamp/c2cgeoportal/blob/2.2/c2cgeoportal/scaffolds/update/CONST_config-schema.yaml forward_headers is allowed in checker sub sections (for example in section defaults).

But in https://github.com/camptocamp/c2cgeoportal/blob/2.2/c2cgeoportal/views/checker.py#L65 it is readed from checker section.

So is no more possible to transfert Cookies through checkers.

arnaud-morvan commented 7 years ago

IMHO, putting it in section defaults seems more flexible and do not need repetition, but as this is not checker specific, but checkers and check_collector wide, this make more sense directly in checker section.

arnaud-morvan commented 7 years ago

Could we consider making the config check against schema not blocking, just a warning.

sbrunner commented 7 years ago

No, not in the generic code, but you can override the concerned rule to make what you want :-)

sbrunner commented 7 years ago

Isn't better to do a pull request to fix that?