search

camptocamp / c2cwsgiutils

BSD 2-Clause "Simplified" License
6 stars 3 forks source link

Redis health check are not activated #837

Closed fredj closed 3 years ago

fredj commented 3 years ago

Redis health check must be added by default but it's not the case when C2C_REDIS_SENTINELS is not set.

See https://github.com/camptocamp/c2cwsgiutils/blob/release_4/c2cwsgiutils/health_check.py#L101: Because C2C_REDIS_SENTINELSis set to an empty string in Dockerfile: https://github.com/camptocamp/c2cwsgiutils/blob/release_4/Dockerfile#L65 the value of C2C_REDIS_URL is not evaluated

fredj commented 3 years ago

Probably the same issue for all the optional variables set to empty string

gberaudo commented 3 years ago

@sbrunner, should this issue be closed?

sbrunner commented 3 years ago

For me yes :-)