search

camptocamp / cgxp

22 stars 22 forks source link

Allow undo and cutWizard to be disabled in Editing #1046

Closed pvalsecc closed 8 years ago

pvalsecc commented 8 years ago

Added two parameters that are true by default:

tsauerwein commented 8 years ago

Looks good to me!

arnaud-morvan commented 8 years ago

For the undo feature, this remove the undo button, but do not deactivate key shortcuts:

https://github.com/camptocamp/cgxp/blob/aa4346ff679af5383eca9f6d2dcf3159daced224/core/src/script/CGXP/plugins/Editing.js#L495

https://github.com/camptocamp/cgxp/blob/9280d767570b7bc05aadadad5abd0cd9f675eea1/geoext.ux/ux/FeatureEditing/lib/GeoExt.ux/FeatureEditorGrid.js#L328

pvalsecc commented 8 years ago

Good catch! The customer ticket was more about the buttons... @arnaud-morvan, do you think I should do another pull request for disabling the key presses as well?

sbrunner commented 8 years ago

I think that's better :-)

arnaud-morvan commented 8 years ago

I also think that it would be more consistent.

pvalsecc commented 8 years ago

OK, pull request there: https://github.com/camptocamp/cgxp/pull/1047